chore(sql): port first(array) to use array sink#6322
Merged
bluestreak01 merged 5 commits intoquestdb:masterfrom Oct 30, 2025
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mcadariu
changed the title
6 tasks
puzpuzpuz
reviewed
Oct 28, 2025
core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstArrayGroupByFunction.java
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstArrayGroupByFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstArrayGroupByFunction.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/groupby/FirstArrayGroupByFunction.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the quick review! |
puzpuzpuz
previously approved these changes
Oct 29, 2025
Contributor
puzpuzpuz
left a comment
puzpuzpuz
left a comment
There was a problem hiding this comment.
nit: would be good to have a dedicated test for the first(array) function.
puzpuzpuz
approved these changes
Oct 29, 2025
Contributor
|
Thanks for going an extra mile with this |
ideoma
changed the title
puzpuzpuz
changed the title
nwoolmer
added a commit
to questdb/documentation
that referenced
this pull request
Nov 16, 2025
Follow-up of questdb/questdb#6291 and questdb/questdb#6322. Co-authored-by: Nick Woolmer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to #4120.
In #6237 the
GroupByArraySinkabstraction was introduced. This enables simplifying theFirstArrayGroupByFunctionbecause it can delegate the manual array handling to it. In addition its implementation will be symmetrical withlast(array)from #6291.