Skip to content

fix(sql): fix NullPointerException in lead() window function when using bind variables [BACKPORT]#6312

Merged
bluestreak01 merged 1 commit intomaster-ent-nextfrom
jh_lead_bind_var_fix_backport
Oct 24, 2025
Merged

fix(sql): fix NullPointerException in lead() window function when using bind variables [BACKPORT]#6312
bluestreak01 merged 1 commit intomaster-ent-nextfrom
jh_lead_bind_var_fix_backport

Conversation

@jerrinot
Copy link
Copy Markdown
Contributor

@jerrinot jerrinot commented Oct 24, 2025

backport of #6264
(cherry picked from commit fb27a5d)

@nwoolmer @jerrinot
fix(sql): fix NullPointerException in lead() window function when usi…
941fb14 
…ng bind variables [BACKPORT]

backport of #6264
(cherry picked from commit fb27a5d)
@jerrinot jerrinot added the Bug Incorrect or unexpected behavior label Oct 24, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jh_lead_bind_var_fix_backport

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

nwoolmer
nwoolmer approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@nwoolmer nwoolmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L G T M

@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Oct 24, 2025

[PR Coverage check]

😍 pass : 21 / 21 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/functions/window/LeadLagWindowFunctionFactoryHelper.java 21 21 100.00%

@bluestreak01 bluestreak01 merged commit 843969c into master-ent-next Oct 24, 2025
32 of 34 checks passed
@bluestreak01 bluestreak01 deleted the jh_lead_bind_var_fix_backport branch October 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nwoolmer nwoolmer nwoolmer approved these changes

Assignees

No one assigned

Labels

Bug Incorrect or unexpected behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerrinot @glasstiger @nwoolmer @bluestreak01