Skip to content

fix(sql): fix sample by negative offset#6306

Merged
bluestreak01 merged 4 commits intomasterfrom
issue#6301
Oct 24, 2025
Merged

fix(sql): fix sample by negative offset#6306
bluestreak01 merged 4 commits intomasterfrom
issue#6301

Conversation

@kafka1991
Copy link
Copy Markdown
Collaborator

close #6301

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue#6301

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 53 / 56 (94.64%)

file detail

path covered line new line coverage
🔵 io/questdb/std/datetime/microtime/Micros.java 5 6 83.33%
🔵 io/questdb/griffin/engine/groupby/YearTimestampNanosSampler.java 11 12 91.67%
🔵 io/questdb/griffin/engine/groupby/YearTimestampMicrosSampler.java 11 12 91.67%
🔵 io/questdb/cairo/mv/TimeZoneIntervalIterator.java 1 1 100.00%
🔵 io/questdb/griffin/engine/groupby/SampleByInterpolateRecordCursorFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/groupby/MonthTimestampMicrosSampler.java 7 7 100.00%
🔵 io/questdb/griffin/engine/groupby/WeekTimestampMicrosSampler.java 2 2 100.00%
🔵 io/questdb/griffin/engine/groupby/MonthTimestampNanosSampler.java 7 7 100.00%
🔵 io/questdb/cairo/mv/FixedOffsetIntervalIterator.java 1 1 100.00%
🔵 io/questdb/griffin/engine/groupby/AbstractNoRecordSampleByCursor.java 1 1 100.00%
🔵 io/questdb/griffin/engine/groupby/WeekTimestampNanosSampler.java 2 2 100.00%
🔵 io/questdb/std/datetime/nanotime/Nanos.java 2 2 100.00%
🔵 io/questdb/griffin/engine/groupby/SimpleTimestampSampler.java 2 2 100.00%

@bluestreak01 bluestreak01 merged commit 763778b into master Oct 24, 2025
34 checks passed
@bluestreak01 bluestreak01 deleted the issue#6301 branch October 24, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample by 1M align to calendar with negative offset groups data incorrectly

3 participants