chore(sql): fix potential NPE in parallel group by#6303
Merged
Conversation
puzpuzpuz
added
the
DO NOT MERGE
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
force-pushed
the
puzpuzpuz_parallel_groupby_smoke_test_npe
branch
from
acd9874 to
336561d
Compare
puzpuzpuz
changed the title
puzpuzpuz
removed
the
DO NOT MERGE
Contributor
[PR Coverage check]😍 pass : 19 / 20 (95.00%) file detail
|
ideoma
approved these changes
Oct 24, 2025
Contributor
Author
|
@ideoma thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6268,
getLong(Record)call oncount_distinctgroup by functions may use theGroupByAllocatorwhen merging partial hash sets. Yet, the allocator was set on group by functions only whengetFunctionUpdater()was called. So, in rare cases when the query owner thread never participated in aggregation and, thus, never called thegetFunctionUpdater()method, an NPE would occur when returning the group by function values to the client.