fix(sql): overflow in materialized view refresh step calculation on large sample by interval#6258
Merged
bluestreak01 merged 3 commits intomasterfrom Oct 10, 2025
Merged
Conversation
…arge sample by interval
puzpuzpuz
added
Bug
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ideoma
reviewed
Oct 10, 2025
ideoma
reviewed
Oct 10, 2025
ideoma
approved these changes
Oct 10, 2025
Contributor
[PR Coverage check]😍 pass : 12 / 15 (80.00%) file detail
|
Contributor
Author
|
@ideoma thanks for the snappy review! |
puzpuzpuz
added a commit
that referenced
this pull request
Oct 22, 2025
…arge sample by interval (#6258)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6257
SampleByIntervalIteratorgot an overflow when calculating the high boundary on large SAMPLE BY intervals and relatively large step value. This is fixed by introducing a newcairo.mat.view.max.refresh.stepconfiguration property (1y by default). The property defines maximum step interval after which refresh falls back to a single SAMPLE BY interval. Example: if refresh job calculates the step of 100 SAMPLE BY 2y intervals, after the check it will fall back to a single 2y interval to avoid overflow issues.