test(core): fix flaky test that tests the stack overflow error (#4139)#6242
Merged
bluestreak01 merged 1 commit intoquestdb:masterfrom Nov 15, 2025
Merged
test(core): fix flaky test that tests the stack overflow error (#4139)#6242bluestreak01 merged 1 commit intoquestdb:masterfrom
bluestreak01 merged 1 commit intoquestdb:masterfrom
Conversation
|
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bluestreak01
changed the title
bluestreak01
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is to solve issue #4139, the original test was expecting error messages contains "stack overflow error", by searching through the entire code base, there's no any Exception class that will produce this kind of error message. Instead, the exception was throw from
io.questdb.griffin.engine.functions.regex.RegexpReplaceStrFunctionFactory.RegexpReplaceStrFunction#getStraround line 148. TheThrowable ewas a stackoverflow exception, but theCairoExceptionthat it is throwing doesn't contain any information about "stack overflow error". I don't really want to mess around with the original code base, my goal is just to fix the flaky test. So I change thetestStackOverFlowError()assert condition to the same string "regexp_replace failed [position=" inio.questdb.griffin.engine.functions.regex.RegexpReplaceStrFunctionFactory.RegexpReplaceStrFunction#getStrline 148 to match the assertion.