Skip to content

fix(core): fix assertion exception in writer, which is triggered by OS error#6204

Merged
bluestreak01 merged 4 commits intomasterfrom
vi_fix_housekeeping
Sep 30, 2025
Merged

fix(core): fix assertion exception in writer, which is triggered by OS error#6204
bluestreak01 merged 4 commits intomasterfrom
vi_fix_housekeeping

Conversation

@bluestreak01
Copy link
Copy Markdown
Member

@bluestreak01 bluestreak01 commented Sep 29, 2025

found by fuzz test:

public void testWalWriteFullRandomMultipleTables() throws Exception {
        Rnd rnd = generateRandom(LOG,631396799652L, 1759158542588L);

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 29, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vi_fix_housekeeping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

ideoma
ideoma reviewed Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ideoma ideoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

puzpuzpuz
puzpuzpuz reviewed Sep 30, 2025
View reviewed changes
puzpuzpuz
puzpuzpuz previously approved these changes Sep 30, 2025
View reviewed changes
@bluestreak01 bluestreak01 merged commit fa57778 into master Sep 30, 2025
5 of 7 checks passed
@bluestreak01 bluestreak01 deleted the vi_fix_housekeeping branch September 30, 2025 13:17
@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Sep 30, 2025

[PR Coverage check]

😍 pass : 1 / 1 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableWriter.java 1 1 100.00%

bluestreak01 added a commit that referenced this pull request Oct 9, 2025
@bluestreak01
fix(core): fix assertion exception in writer, which is triggered by O…
3d1b1ac 
…S error (#6204)

(cherry picked from commit fa57778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ideoma ideoma ideoma left review comments

@puzpuzpuz puzpuzpuz puzpuzpuz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bluestreak01 @glasstiger @ideoma @puzpuzpuz