Skip to content

fix(sql): consistent behaviour of EXPLAIN command#6200

Merged
bluestreak01 merged 2 commits intomasterfrom
ia_explain
Sep 28, 2025
Merged

fix(sql): consistent behaviour of EXPLAIN command#6200
bluestreak01 merged 2 commits intomasterfrom
ia_explain

Conversation

@glasstiger
Copy link
Copy Markdown
Contributor

@glasstiger glasstiger commented Sep 27, 2025

For most EXPLAIN commands the database checks if the user has the necessary permissions to execute the statement behind EXPLAIN.
This is not the case for CREATE TABLE and CREATE MATERIALIZED VIEW.
Added compile time authorization for these commands.
Also made sure there is a proper error message for EXPLAIN DROP, EXPLAIN ALTER and EXPLAIN REFRESH.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 27, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ia_explain

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glasstiger
Copy link
Copy Markdown
Contributor Author

[PR Coverage check]

😍 pass : 5 / 5 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/SqlParser.java 3 3 100.00%
🔵 io/questdb/griffin/SqlCompilerImpl.java 2 2 100.00%

@bluestreak01 bluestreak01 changed the title fix(core): consistent behaviour of EXPLAIN command fix(sql): consistent behaviour of EXPLAIN command Sep 27, 2025
@bluestreak01 bluestreak01 merged commit 16768c4 into master Sep 28, 2025
37 checks passed
@bluestreak01 bluestreak01 deleted the ia_explain branch September 28, 2025 20:37
bluestreak01 pushed a commit that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants