fix(ilp): avoid closing connection on protocol errors#6190
Merged
bluestreak01 merged 6 commits intomasterfrom Sep 25, 2025
Merged
fix(ilp): avoid closing connection on protocol errors#6190bluestreak01 merged 6 commits intomasterfrom
bluestreak01 merged 6 commits intomasterfrom
Conversation
puzpuzpuz
added
Bug
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bluestreak01
previously approved these changes
Sep 25, 2025
bluestreak01
approved these changes
Sep 25, 2025
Contributor
[PR Coverage check]😍 pass : 7 / 9 (77.78%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to close the ILP/TCP connection and the writer on cast error like the below one:
The scenario is when you're trying to send a value of wrong type for the given column, i.e. a
floatinstead of astring(LineTcpReceiverTest.testColumnTypeStaysTheSameWhileColumnAdded). This patch keeps the connection open ifline.tcp.disconnect.on.erroris set tofalse. The error is also no longer logged with critical level.