Skip to content

feat(sql): add symbol table size to SHOW COLUMNS SQL#6128

Merged
bluestreak01 merged 5 commits intomasterfrom
puzpuzpuz_show_columns_symbol_table_size
Sep 15, 2025
Merged

feat(sql): add symbol table size to SHOW COLUMNS SQL#6128
bluestreak01 merged 5 commits intomasterfrom
puzpuzpuz_show_columns_symbol_table_size

Conversation

@puzpuzpuz
Copy link
Copy Markdown
Contributor

@puzpuzpuz puzpuzpuz commented Sep 11, 2025 •
edited
Loading

Adds new symbolTableSize column to the SHOW COLUMNS output. The column contains the number of symbol dictionary codes present in the symbol table.

Also fixes table reader initialization in case of zero-columns table:

create table x (arr double[]);
alter table x drop column arr;
x; -- this used to fail

@puzpuzpuz puzpuzpuz self-assigned this Sep 11, 2025
@puzpuzpuz puzpuzpuz added Enhancement Enhance existing functionality SQL Issues or changes relating to SQL execution labels Sep 11, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 11, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch puzpuzpuz_show_columns_symbol_table_size

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@puzpuzpuz puzpuzpuz changed the title Add symbol table size to SHOW COLUMNS SQL feat(sql): add symbol table size to SHOW COLUMNS SQL Sep 11, 2025
@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Sep 12, 2025

[PR Coverage check]

😍 pass : 27 / 27 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cairo/TableReader.java 1 1 100.00%
🔵 io/questdb/griffin/engine/table/ShowColumnsRecordCursorFactory.java 26 26 100.00%

@bluestreak01 bluestreak01 merged commit 7eb1a51 into master Sep 15, 2025
35 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_show_columns_symbol_table_size branch September 15, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

Assignees

@puzpuzpuz puzpuzpuz

Labels

Enhancement Enhance existing functionality SQL Issues or changes relating to SQL execution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@puzpuzpuz @glasstiger @bluestreak01