Skip to content

fix(ilp): fix retrying when fetching server protocol version#6099

Merged
ideoma merged 2 commits intomasterfrom
jh_retry_when_fetching_settings
Sep 3, 2025
Merged

fix(ilp): fix retrying when fetching server protocol version#6099
ideoma merged 2 commits intomasterfrom
jh_retry_when_fetching_settings

Conversation

@jerrinot
Copy link
Copy Markdown
Contributor

@jerrinot jerrinot commented Sep 3, 2025 •
edited
Loading

This PR improves the reliability of the HTTP Line Protocol sender by adding automatic retry logic when fetching server configuration during initial connection setup. This makes the client more resilient to transient network issues and server restarts.

Technical Details

  • Retries are attempted for up to the configured maxRetriesNanos duration
  • Only retries on server errors (500, 503, 504, 507, 509, 523, 524, 529, 599) and network failures
  • Maintains the same retry behavior for both initial connection setup and data flushing operations
  • Success is now defined as any 2xx status code (previously only 200 for settings fetch)

@jerrinot jerrinot added Bug Incorrect or unexpected behavior ILP Issues or changes relating to Influx Line Protocol labels Sep 3, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 3, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jh_retry_when_fetching_settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jerrinot jerrinot changed the title fix(ilp): fix retrying when fetching server settings fix(ilp): fix retrying when fetching server protocol version Sep 3, 2025
@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Sep 3, 2025

[PR Coverage check]

😍 pass : 26 / 33 (78.79%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/line/http/AbstractLineHttpSender.java 25 32 78.12%
🔵 io/questdb/cutlass/line/http/LineHttpSenderV2.java 1 1 100.00%

@ideoma ideoma merged commit 3efcb4a into master Sep 3, 2025
36 checks passed
@ideoma ideoma deleted the jh_retry_when_fetching_settings branch September 3, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ideoma ideoma ideoma approved these changes

Assignees

No one assigned

Labels

Bug Incorrect or unexpected behavior ILP Issues or changes relating to Influx Line Protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerrinot @glasstiger @ideoma