core/src/test/java/io/questdb/test/griffin/InsertCastTest.java (2)

1342-1342: Typo: fix comment “bar array” → “bad array”

Minor nit.

Apply this diff:

-            // bar array
+            // bad array

---

1347-1351: Confirm intent: error message reports from-type as STRING even for VARCHAR input

The expected message uses [STRING -> DOUBLE[][]] although the input is cast as VARCHAR. This matches the current implementation (SqlUtil.implicitCastVarcharAsDoubleArray throws with from-type STRING). If this is the intended UX to unify error messaging across STRING/VARCHAR for array parsing, all good. If not, consider aligning the from-type to VARCHAR in both code and tests.

core/src/main/java/io/questdb/griffin/SqlUtil.java (1)

879-889: Clarify why exceptions use from-type STRING for VARCHAR input

The implementation intentionally throws ImplicitCastException with from-type STRING for VARCHAR inputs. This matches tests, but differs from other VARCHAR casts (which report VARCHAR). Consider documenting this to avoid confusion for future maintainers.

Apply this diff to add a brief rationale comment:

     public static ArrayView implicitCastVarcharAsDoubleArray(Utf8Sequence value, DoubleArrayParser parser, int expectedType) {
+        // Note: We deliberately report the source type as STRING in error messages, even though the input is VARCHAR.
+        // Arrays are parsed from an ASCII CharSequence (value.asAsciiCharSequence()), and existing array-cast errors
+        // are standardized to [STRING -> <ARRAY_TYPE>] across STRING/VARCHAR inputs.
         try {
             parser.of(value.asAsciiCharSequence(), ColumnType.decodeArrayDimensionality(expectedType));
         } catch (IllegalArgumentException e) {
             throw ImplicitCastException.inconvertibleValue(value, ColumnType.STRING, expectedType);
         }
         if (expectedType != ColumnType.UNDEFINED && parser.getType() != expectedType) {
             throw ImplicitCastException.inconvertibleValue(value, ColumnType.STRING, expectedType);
         }
         return parser;
     }

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.