perf(sql): rewrite trivial expressions over same column in GROUP BY queries#6043
Merged
bluestreak01 merged 31 commits intomasterfrom Sep 26, 2025
Merged
perf(sql): rewrite trivial expressions over same column in GROUP BY queries#6043bluestreak01 merged 31 commits intomasterfrom
bluestreak01 merged 31 commits intomasterfrom
Conversation
…ueries Co-authored-by: Nick Woolmer <[email protected]>
puzpuzpuz
added
SQL
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
puzpuzpuz
changed the title
puzpuzpuz
force-pushed
the
nw_rewrite_trivial_expr
branch
from
5cf2dd7 to
332a5eb
Compare
core/src/main/java/io/questdb/cutlass/text/types/IPv4Adapter.java
Outdated
Show resolved
Hide resolved
puzpuzpuz
force-pushed
the
nw_rewrite_trivial_expr
branch
from
feb2fbf to
5042162
Compare
core/src/main/java/io/questdb/cutlass/text/types/IPv4Adapter.java
Outdated
Show resolved
Hide resolved
Contributor
[PR Coverage check]😍 pass : 127 / 128 (99.22%) file detail
|
bluestreak01
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4141
Continuation of #4508
Also includes the following:
yyyy-mm-dddate format to default text loader formats.Benchmarks
With these changes we get an improvement in Q35 from ClickBench. The hot execution times on my 12c/24t Linux box are the following: