fix(sql): reduce write amplification for materialized views with small SAMPLE BY interval#5995
Merged
bluestreak01 merged 5 commits intomasterfrom Jul 30, 2025
Merged
Conversation
…l SAMPLE BY interval
puzpuzpuz
added
Bug
ideoma
approved these changes
Jul 30, 2025
Contributor
Author
|
@ideoma thanks for the review! |
Contributor
[PR Coverage check]😍 pass : 12 / 12 (100.00%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes minimal refresh interval defined by
cairo.mat.view.min.refresh.intervalproperty. This property and its associated logic led to larger refresh interval being used in case of base table commits with a small time interval (e.g. a single timestamp commit). For instance, in case of a SAMPLE BY 1s even in case of a single timestamp commit the final refresh interval was 100s.