fix(http): fix exception thrown when using escaped column names#5927
Merged
bluestreak01 merged 8 commits intomasterfrom Jul 10, 2025
Merged
fix(http): fix exception thrown when using escaped column names#5927bluestreak01 merged 8 commits intomasterfrom
bluestreak01 merged 8 commits intomasterfrom
Conversation
bluestreak01
reviewed
Jul 9, 2025
core/src/test/java/io/questdb/test/cutlass/http/IODispatcherTest.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Jul 9, 2025
core/src/main/java/io/questdb/cutlass/http/processors/JsonQueryProcessorState.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Jul 9, 2025
core/src/main/java/io/questdb/cutlass/http/processors/JsonQueryProcessorState.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Jul 9, 2025
core/src/main/java/io/questdb/cutlass/http/processors/JsonQueryProcessorState.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Jul 9, 2025
core/src/main/java/io/questdb/cutlass/http/processors/JsonQueryProcessorState.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Jul 9, 2025
core/src/main/java/io/questdb/cutlass/http/processors/JsonQueryProcessorState.java
Outdated
Show resolved
Hide resolved
bluestreak01
reviewed
Jul 9, 2025
core/src/main/java/io/questdb/cutlass/http/processors/JsonQueryProcessorState.java
Outdated
Show resolved
Hide resolved
Member
|
PR is solid, just needs cleanup for legibility |
Contributor
[PR Coverage check]😍 pass : 70 / 70 (100.00%) file detail
|
bluestreak01
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (with ui#452) fixes a bug that occurs when users have commas in their column names and uses the
colsquery parameter in the HTTP processor.In order to fix the bug, ui#452 stringifies column names before sending them through the wire and this PR handles double quotes and escape character.