perf(sql): speed up initial refresh of materialized views with high cardinality symbols#5906
Merged
bluestreak01 merged 4 commits intomasterfrom Jul 8, 2025
Merged
Conversation
puzpuzpuz
added
SQL
jerrinot
previously approved these changes
Jul 8, 2025
jerrinot
approved these changes
Jul 8, 2025
Contributor
Author
|
@jerrinot thanks for the review! |
Contributor
[PR Coverage check]😍 pass : 8 / 9 (88.89%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The append page size for symbol writer used to be set to 4KB (OS page size). Now it's set to 256KB.
Minimal reproducer:
Before this patch the INSERT takes 30+ minutes (I wasn't patient enough to get the exact duration). With this patch, it's 20 seconds.