feat(sql): ALTER MATERIALIZED VIEW SET REFRESH support#5896
Merged
bluestreak01 merged 59 commits intomasterfrom Jul 10, 2025
Merged
feat(sql): ALTER MATERIALIZED VIEW SET REFRESH support#5896bluestreak01 merged 59 commits intomasterfrom
bluestreak01 merged 59 commits intomasterfrom
Conversation
… in case of manual and timer materialized views
…into puzpuzpuz_mat_view_wal_purge
puzpuzpuz
added
New feature
ideoma
previously approved these changes
Jul 8, 2025
| ); | ||
| updateMatViewDefinition(newDefinition); | ||
| } finally { | ||
| path.trimTo(pathSize); |
Collaborator
There was a problem hiding this comment.
We don't use path here, debis?
Contributor
Author
There was a problem hiding this comment.
Moved to updateMatViewDefinition() in 71117f1
I also noticed that we were publishing timer tasks before the mat view state is initialized. This is not a big deal as in that case timer job does nothing when the timer is triggered until the state is initialized, but make thing more aligned, I moved publishing timer tasks to state store in 98b0783
ideoma
approved these changes
Jul 9, 2025
Contributor
Author
|
@ideoma thanks for the review! |
Contributor
[PR Coverage check]😍 pass : 241 / 267 (90.26%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes possible to change any of the REFRESH settings for the given materialized view. Example: