test(sql): fix flaky testQueryTimeout() due to WAL apply race condition#5790
Merged
bluestreak01 merged 2 commits intomasterfrom Jun 27, 2025
Merged
test(sql): fix flaky testQueryTimeout() due to WAL apply race condition#5790bluestreak01 merged 2 commits intomasterfrom
bluestreak01 merged 2 commits intomasterfrom
Conversation
The test assumes that drainWalQueue() guarantees the WAL is fully applied when it returns. However, this assumption only holds when there's no background WAL apply job running. When a background job exists, it competes with drainWalQueue() to process the queue. This creates a race condition where: 1. The background job dequeues and begins applying a WAL entry 2. drainWalQueue() sees an empty queue and returns 3. The test's query assertion runs before the background job completes 4. The assertion fails because it sees the table in a pre-WAL state
jerrinot
added
the
Flaky Test
mtopolnik
previously approved these changes
Jun 27, 2025
clippy was moaning on the latest Rust toolchain (1.88.0)
mtopolnik
approved these changes
Jun 27, 2025
Contributor
[PR Coverage check]😍 pass : 0 / 0 (0%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test assumes that
drainWalQueue()guarantees the WAL is fully applied when it returns. However, this assumption only holds when there's no background WAL apply job running.When a background job exists, it competes with
drainWalQueue()to process the queue. This creates a race condition where:drainWalQueue()sees an empty queue and returns