fix(sql): make sample by week align to natural calendar.#5785
Merged
bluestreak01 merged 5 commits intomasterfrom Jun 30, 2025
Merged
fix(sql): make sample by week align to natural calendar.#5785bluestreak01 merged 5 commits intomasterfrom
sample by week align to natural calendar.#5785bluestreak01 merged 5 commits intomasterfrom
Conversation
…ligns to natural dates.
…ligns to natural dates.
ideoma
approved these changes
Jun 30, 2025
Contributor
[PR Coverage check]😍 pass : 2 / 2 (100.00%) file detail
|
This was referenced Jun 30, 2025
|
Hi @kafka1991, I checked the code. Thanks for the quick reaction! If I understand correctly: I do have a question, why is the 1970 Thursday subtraction not applied when an offset is given? |
Collaborator
Author
Hi, @bobreim If an offset is provided in the input, it means the offset serves as the baseline. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
SAMPLE BY weekstatement does not specify aFROMclause, it need to align to natural calendar.close ##5776