Skip to content

fix(ilp): UnsupportedOperationException when writing to non-WAL table via ILP/TCP#5742

Merged
bluestreak01 merged 4 commits intomasterfrom
issue#5740
Aug 11, 2025
Merged

fix(ilp): UnsupportedOperationException when writing to non-WAL table via ILP/TCP#5742
bluestreak01 merged 4 commits intomasterfrom
issue#5740

Conversation

@kafka1991
Copy link
Copy Markdown
Collaborator

@kafka1991 kafka1991 commented Jun 13, 2025

Change the method of judging whether it is a WAL table in TableUpdateDetails.
Close #5740

@kafka1991 kafka1991 changed the title fix(ILP): Change the method of judging whether it is a WAL table in `TableUpdat… fix(ilp): Change the method of judging whether it is a WAL table in `TableUpdat… Jun 13, 2025
@puzpuzpuz
Copy link
Copy Markdown
Contributor

puzpuzpuz commented Jun 13, 2025

Do you have a reproducer for #5740? Without a reproducer test it's hard to say whether this patch fixes the bug or not.

@puzpuzpuz puzpuzpuz changed the title fix(ilp): Change the method of judging whether it is a WAL table in `TableUpdat… fix(ilp): UnsupportedOperationException when writing to non-WAL table via ILP/TCP Jun 13, 2025
@kafka1991
Copy link
Copy Markdown
Collaborator Author

kafka1991 commented Jun 13, 2025 •
edited
Loading

Do you have a reproducer for #5740? Without a reproducer test it's hard to say whether this patch fixes the bug or not.

Hi, @puzpuzpuz

It wasn't reproduced, but rather inferred from the code.

I think the changes have no side effects so far.

@puzpuzpuz
Copy link
Copy Markdown
Contributor

puzpuzpuz commented Jun 13, 2025

Without a reproducer we can't be certain that the fix is complete, so it'd be great to find a reproducer.

@kafka1991
Copy link
Copy Markdown
Collaborator Author

kafka1991 commented Jun 16, 2025

Without a reproducer we can't be certain that the fix is complete, so it'd be great to find a reproducer.

Yeah, you are right. Will try to reproduce it later.

@kafka1991
Copy link
Copy Markdown
Collaborator Author

kafka1991 commented Jun 27, 2025

Without a reproducer we can't be certain that the fix is complete, so it'd be great to find a reproducer.

Add concurrent write and truncate/drop table tests and not reproduce the issue on master branch.

@glasstiger
Copy link
Copy Markdown
Contributor

glasstiger commented Jul 2, 2025

[PR Coverage check]

😍 pass : 1 / 1 (100.00%)

file detail

path covered line new line coverage
🔵 io/questdb/cutlass/line/tcp/TableUpdateDetails.java 1 1 100.00%

@bluestreak01 bluestreak01 merged commit e461e7d into master Aug 11, 2025
37 checks passed
@bluestreak01 bluestreak01 deleted the issue#5740 branch August 11, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluestreak01 bluestreak01 bluestreak01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UnsupportedOperationException in ILP/TCP

4 participants

@kafka1991 @puzpuzpuz @glasstiger @bluestreak01