feat(sql): allow self-UNION queries in materialized views#5730
Merged
bluestreak01 merged 3 commits intomasterfrom Jun 16, 2025
Merged
feat(sql): allow self-UNION queries in materialized views#5730bluestreak01 merged 3 commits intomasterfrom
bluestreak01 merged 3 commits intomasterfrom
Conversation
puzpuzpuz
added
Enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR relaxes the materialized view validator to allow self-UNION on the base table while still prohibiting unions involving other tables.
- Update
validateMatViewQueryto track all referenced tables and permit self-UNION only when no other tables are involved - Remove the old
isTableQueriedhelper and replace it withcollectAllTableNames - Add tests for successful self-UNION and failure when unioning with a non-base table; remove the obsolete union test
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CreateMatViewTest.java | Added tests for self-UNION support and failing non-base-table unions; removed outdated union test |
| SqlParser.java | Replaced isTableQueried logic with collectAllTableNames, updated validation to allow self-UNION |
Comments suppressed due to low confidence (1)
core/src/test/java/io/questdb/test/cairo/mv/CreateMatViewTest.java:197
- Test only covers
UNION(distinct). Add a variant withUNION ALLintestCreateMatViewBaseTableSelfUnionto ensure both forms are allowed.
union
Contributor
[PR Coverage check]😍 pass : 11 / 11 (100.00%) file detail
|
bluestreak01
approved these changes
Jun 16, 2025
mtopolnik
pushed a commit
that referenced
this pull request
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxes UNION restriction for materialized view queries. Namely, self-UNION on base table is now allowed.