Skip to content

fix(sql): failing OOM recovery due to too strict RSS limit checks#5717

Merged
bluestreak01 merged 6 commits intomasterfrom
puzpuzpuz_flaky_parallel_oom_test
Jun 3, 2025
Merged

fix(sql): failing OOM recovery due to too strict RSS limit checks#5717
bluestreak01 merged 6 commits intomasterfrom
puzpuzpuz_flaky_parallel_oom_test

Conversation

@puzpuzpuz
Copy link
Copy Markdown
Contributor

@puzpuzpuz puzpuzpuz commented Jun 3, 2025

In memory pressure scenarios, PageFrameSequence threw OOM exception on close() and couldn't recover from that. As a result, reader & mem leaks happened.

@puzpuzpuz puzpuzpuz self-assigned this Jun 3, 2025
@puzpuzpuz puzpuzpuz marked this pull request as ready for review June 3, 2025 08:16
@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 14 / 21 (66.67%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/QueryProgress.java 0 7 00.00%
🔵 io/questdb/cairo/sql/async/PageFrameSequence.java 2 2 100.00%
🔵 io/questdb/std/DirectIntList.java 6 6 100.00%
🔵 io/questdb/std/DirectLongList.java 6 6 100.00%

@puzpuzpuz
Copy link
Copy Markdown
Contributor Author

@mtopolnik thanks for the review!

@bluestreak01 bluestreak01 merged commit 71b165c into master Jun 3, 2025
37 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_flaky_parallel_oom_test branch June 3, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants