Skip to content

fix(sql): unreliable out-of-memory error propagation in parallel SQL#5711

Merged
bluestreak01 merged 1 commit intomasterfrom
puzpuzpuz_parallel_oom_propagation
Jun 2, 2025
Merged

fix(sql): unreliable out-of-memory error propagation in parallel SQL#5711
bluestreak01 merged 1 commit intomasterfrom
puzpuzpuz_parallel_oom_propagation

Conversation

@puzpuzpuz
Copy link
Copy Markdown
Contributor

Proper OOM error propagation is important for mat view refresh job since it has a back-off logic where it shrinks the queried interval size.

@puzpuzpuz puzpuzpuz self-assigned this May 30, 2025
@puzpuzpuz puzpuzpuz added Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution labels May 30, 2025
@glasstiger
Copy link
Copy Markdown
Contributor

[PR Coverage check]

😍 pass : 35 / 36 (97.22%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/groupby/vect/GroupByRecordCursorFactory.java 15 16 93.75%
🔵 io/questdb/griffin/engine/table/AsyncFilteredNegativeLimitRecordCursor.java 4 4 100.00%
🔵 io/questdb/griffin/engine/table/AsyncFilteredRecordCursor.java 2 2 100.00%
🔵 io/questdb/griffin/engine/table/AsyncGroupByNotKeyedRecordCursor.java 4 4 100.00%
🔵 io/questdb/cairo/sql/async/PageFrameReduceTask.java 6 6 100.00%
🔵 io/questdb/griffin/engine/table/AsyncGroupByRecordCursor.java 4 4 100.00%

@bluestreak01 bluestreak01 merged commit 38e7073 into master Jun 2, 2025
37 checks passed
@bluestreak01 bluestreak01 deleted the puzpuzpuz_parallel_oom_propagation branch June 2, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Incorrect or unexpected behavior SQL Issues or changes relating to SQL execution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants