fix(sql): potential memory leak in plain INSERTs#5706
Merged
bluestreak01 merged 7 commits intomasterfrom May 30, 2025
Merged
Conversation
puzpuzpuz
added
Bug
Contributor
|
How come this was not caught by existing tests? |
Contributor
Author
That's simple: we had no tests with off-heap SQL functions in INSERT. |
Contributor
|
@mtopolnik this is like a deje-vu:
I swear we dealt with this before. |
Contributor
Author
|
|
Contributor
Author
|
@jerrinot fancy doing a code review? |
Contributor
|
@puzpuzpuz sure |
jerrinot
reviewed
May 30, 2025
core/src/main/java/io/questdb/cutlass/pgwire/modern/PGPipelineEntry.java
Show resolved
Hide resolved
Contributor
[PR Coverage check]😍 pass : 48 / 51 (94.12%) file detail
|
Contributor
Author
|
@jerrinot BTW many thanks for adding pgwire driver tests - they're of a great help when it comes to tricky scenarios. Without them this patch would certainly break some clients. |
jerrinot
approved these changes
May 30, 2025
Contributor
Author
|
@jerrinot @mtopolnik thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes potential memory leak in plain INSERTs: timestamp and record SQL functions were never closed