fix(sql): improve null-handling of INSERT INTO SELECT queries that rely on implicit casting#5586
fix(sql): improve null-handling of INSERT INTO SELECT queries that rely on implicit casting#5586bluestreak01 merged 18 commits intomasterfrom
INSERT INTO SELECT queries that rely on implicit casting#5586Conversation
# Conflicts: # core/src/test/java/io/questdb/test/griffin/SqlCompilerImplTest.java
# Conflicts: # core/src/main/java/io/questdb/griffin/SqlCodeGenerator.java
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…(date, long) -> in both cases we return date. this makes it consistent with commonWideningType(timestamp, long) and commonWideningType(long, timestamp)
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Thanks @jerrinot! |
[PR Coverage check]😍 pass : 40 / 40 (100.00%) file detail
|
RecordToRowCopierutils had some copy functions that were not null aware. In one example, a nullLONGcolumn would be converted toDOUBLE. But instead of theLONGnull value becoming aDouble.NaN, it stays as min long.Fixes https://community.questdb.com/t/null-2147483648-or-what-am-i-doing-wrong/807/6
Fixes #5291