fix(sql): ordering by alphanumeric columns that start with a number#5408
Merged
bluestreak01 merged 6 commits intomasterfrom Feb 28, 2025
Merged
fix(sql): ordering by alphanumeric columns that start with a number#5408bluestreak01 merged 6 commits intomasterfrom
bluestreak01 merged 6 commits intomasterfrom
Conversation
nwoolmer
added
Bug
nwoolmer
changed the title
bluestreak01
requested changes
Feb 21, 2025
bluestreak01
approved these changes
Feb 28, 2025
Contributor
[PR Coverage check]😍 pass : 0 / 0 (0%) |
This was referenced Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5407
When rewriting queries that use positional order by (i.e.
ORDER BY 1, 2), column names that started with a number were mistakenly interpreted as numbers. Then, they would fail to parse to an integer.Now, the code first verifies that it is truly numeric. If not, it will fall out and not attempt to rewrite from positional order by to a named order by.