feat(sql): multi-threaded read_parquet() execution#5256
Merged
bluestreak01 merged 13 commits intomasterfrom Jan 15, 2025
Merged
feat(sql): multi-threaded read_parquet() execution#5256bluestreak01 merged 13 commits intomasterfrom
bluestreak01 merged 13 commits intomasterfrom
Conversation
Contributor
Author
|
@nwoolmer the PR should be ready for review now. PTAL |
ideoma
previously approved these changes
Jan 14, 2025
mtopolnik
reviewed
Jan 14, 2025
core/src/main/java/io/questdb/griffin/engine/functions/table/ReadParquetPageFrameCursor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/questdb/griffin/engine/functions/table/ReadParquetPageFrameCursor.java
Outdated
Show resolved
Hide resolved
mtopolnik
previously approved these changes
Jan 14, 2025
Contributor
Author
|
@mtopolnik thanks for the review! |
bluestreak01
previously approved these changes
Jan 15, 2025
bluestreak01
approved these changes
Jan 15, 2025
Contributor
[PR Coverage check]😍 pass : 145 / 164 (88.41%) file detail
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5250
read_parquet()SQL function now supports parallel execution. This means that parallel filtering and aggregation supported by QuestDB's query engine now apply toread_parquet()as if it was a native table.Note: we don't support projection for virtual table functions like
read_parquet(), so if you have, say, 1000 columns in your parquet, but you query only a single column, we'll end up decoding all 1000 columns. This is something to improve in future. Tracked in #5280Parallel
read_parquet()execution can be disabled with newcairo.sql.parallel.read.parquet.enabledconfiguration property.Also includes the following:
PageFrameCursorinterfaceTODOs:
PageFrameCursorinto a childTablePageFrameCursorinterface and use it where appropriate.read_parquet().