Address review comments

ideoma · claude · ideoma · commit 51e06a2695cd · 2026-02-24T13:42:46.000Z
- Normalize txnMinTimestamp/txnMaxTimestamp to Numbers.LONG_NULL for empty
  commits before emitting telemetry (avoids bogus Long.MAX_VALUE/-1 values)
- Sort WAL_TXN_COMMITTED constant alphabetically in TelemetryEvent
- Sort telemetryWal and walTelemetryEnabled fields alphabetically in WalWriter
- Replace assertSql with assertQueryNoLeakCheck in TelemetryTest

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/core/src/main/java/io/questdb/TelemetryEvent.java b/core/src/main/java/io/questdb/TelemetryEvent.java
@@ -61,8 +61,8 @@ public final class TelemetryEvent {
     public static final short VIEW_DROP = 211;
     public static final short WAL_APPLY_RESUME = 108;
     public static final short WAL_APPLY_SUSPEND = 107;
-    public static final short WAL_TXN_COMMITTED = 109;
     public static final short WAL_TXN_APPLY_START = 103;
+    public static final short WAL_TXN_COMMITTED = 109;
     public static final short WAL_TXN_DATA_APPLIED = 105;
     public static final short WAL_TXN_SQL_APPLIED = 106;
     public static final short WAL_TXN_STRUCTURE_CHANGE_APPLIED = 104;
diff --git a/core/src/main/java/io/questdb/cairo/wal/WalWriter.java b/core/src/main/java/io/questdb/cairo/wal/WalWriter.java
@@ -123,7 +123,6 @@ public class WalWriter extends WalWriterBase implements TableWriterAPI {
     private final MetadataService metaWriterSvc = new MetadataWriterService();
     private final WalWriterMetadata metadata;
     private final Metrics metrics;
-    private final Telemetry<TelemetryWalTask> telemetryWal;
     private final ObjList<Runnable> nullSetters;
     private final RecentWriteTracker recentWriteTracker;
     private final RowImpl row = new RowImpl();
@@ -132,11 +131,12 @@ public class WalWriter extends WalWriterBase implements TableWriterAPI {
     private final BoolList symbolMapNullFlagsChanged = new BoolList();
     private final ObjList<SymbolMapReader> symbolMapReaders = new ObjList<>();
     private final ObjList<DirectCharSequenceIntHashMap> symbolMaps = new ObjList<>();
-    private final boolean walTelemetryEnabled;
+    private final Telemetry<TelemetryWalTask> telemetryWal;
     private final TimestampDriver timestampDriver;
     private final int timestampIndex;
     private final ObjList<Utf8StringIntHashMap> utf8SymbolMaps = new ObjList<>();
     private final Uuid uuid = new Uuid();
+    private final boolean walTelemetryEnabled;
     private long avgRecordSize;
     private SegmentColumnRollSink columnConversionSink;
     private int columnCount;
@@ -891,6 +891,12 @@ private void commit0(
                 syncIfRequired();
                 final long seqTxn = getSequencerTxn();
                 if (walTelemetryEnabled) {
+                    final long minTs = (txnRowCount == 0 || txnMinTimestamp == Long.MAX_VALUE)
+                            ? Numbers.LONG_NULL
+                            : txnMinTimestamp;
+                    final long maxTs = (txnRowCount == 0 || txnMaxTimestamp < 0)
+                            ? Numbers.LONG_NULL
+                            : txnMaxTimestamp;
                     TelemetryWalTask.store(
                             telemetryWal,
                             TelemetryEvent.WAL_TXN_COMMITTED,
@@ -900,8 +906,8 @@ private void commit0(
                             txnRowCount,
                             txnRowCount,
                             0L,
-                            txnMinTimestamp,
-                            txnMaxTimestamp
+                            minTs,
+                            maxTs
                     );
                 }
                 final boolean hasReplaceRange = replaceRangeHiTs > replaceRangeLowTs;
diff --git a/core/src/test/java/io/questdb/test/TelemetryTest.java b/core/src/test/java/io/questdb/test/TelemetryTest.java
@@ -411,9 +411,9 @@ public void testTelemetryWalTableUpgrade() throws Exception {
                     "\tlatency FLOAT\n";
             String end = " BYPASS WAL;\n";
 
-            assertSql(header + ") timestamp(created) PARTITION BY MONTH" + end, showCreateTable);
+            assertQueryNoLeakCheck(header + ") timestamp(created) PARTITION BY MONTH" + end, showCreateTable);
             try (TelemetryJob ignore = new TelemetryJob(engine)) {
-                assertSql(header.replace("\tlatency FLOAT\n", "\tlatency FLOAT,\n") +
+                assertQueryNoLeakCheck(header.replace("\tlatency FLOAT\n", "\tlatency FLOAT,\n") +
                         "\tminTimestamp TIMESTAMP,\n" +
                         "\tmaxTimestamp TIMESTAMP\n" +
                         ") timestamp(created) PARTITION BY DAY TTL 1 WEEK" + end, showCreateTable);
