test(sql): fix flaky BitmapIndexConcurrentTest (#6059)

jerrinot · web-flow · commit 281eea441294 · 2025-08-18T12:13:57.000+01:00
diff --git a/core/src/test/java/io/questdb/test/cairo/BitmapIndexConcurrentFuzzTest.java b/core/src/test/java/io/questdb/test/cairo/BitmapIndexConcurrentFuzzTest.java
@@ -47,7 +47,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReference;
 
-public class BitmapIndexConcurrentTest extends AbstractCairoTest {
+public class BitmapIndexConcurrentFuzzTest extends AbstractCairoTest {
     private static final int MAX_ID = 100;
 
     @Test
@@ -217,45 +217,47 @@ private void testConcurrentOperations(Rnd masterRnd) throws Exception {
                     startBarrier.await(); // Wait for all threads to be ready
 
                     Rnd rnd = new Rnd(seed0, seed1); // Unique deterministic seeds per thread
-                    while (!stopFlag.get() && errorCount.get() == 0) {
-                        try {
-                            String randomSymbol = "SYM" + (rnd.nextInt(100) + 1);
-                            String querySql = String.format(
-                                    "SELECT symbol, count(*) FROM trades WHERE symbol = '%s' GROUP BY symbol",
-                                    randomSymbol
-                            );
-
-                            try (RecordCursorFactory factory = select(querySql)) {
-                                try (RecordCursor cursor = factory.getCursor(sqlExecutionContext)) {
-                                    int rowCount = 0;
-                                    CharSequence foundSymbol = null;
-
-                                    while (cursor.hasNext()) {
-                                        rowCount++;
-                                        if (rowCount > 1) {
+                    try (var threadLocalContext = TestUtils.createSqlExecutionCtx(engine)) {
+                        while (!stopFlag.get() && errorCount.get() == 0) {
+                            try {
+                                String randomSymbol = "SYM" + (rnd.nextInt(100) + 1);
+                                String querySql = String.format(
+                                        "SELECT symbol, count(*) FROM trades WHERE symbol = '%s' GROUP BY symbol",
+                                        randomSymbol
+                                );
+
+                                try (RecordCursorFactory factory = select(querySql, threadLocalContext)) {
+                                    try (RecordCursor cursor = factory.getCursor(threadLocalContext)) {
+                                        int rowCount = 0;
+                                        CharSequence foundSymbol = null;
+
+                                        while (cursor.hasNext()) {
+                                            rowCount++;
+                                            if (rowCount > 1) {
+                                                errorCount.incrementAndGet();
+                                                firstError.compareAndSet(null, new AssertionError("Reader " + threadId + ": Multiple rows for symbol " + randomSymbol));
+                                                return;
+                                            }
+                                            foundSymbol = cursor.getRecord().getSymA(0);
+                                        }
+
+                                        if (rowCount == 1 && !Chars.equals(foundSymbol, randomSymbol)) {
                                             errorCount.incrementAndGet();
-                                            firstError.compareAndSet(null, new AssertionError("Reader " + threadId + ": Multiple rows for symbol " + randomSymbol));
+                                            firstError.compareAndSet(null, new AssertionError("Reader " + threadId + ": Expected " + randomSymbol + " but got " + foundSymbol));
                                             return;
                                         }
-                                        foundSymbol = cursor.getRecord().getSymA(0);
-                                    }
 
-                                    if (rowCount == 1 && !Chars.equals(foundSymbol, randomSymbol)) {
-                                        errorCount.incrementAndGet();
-                                        firstError.compareAndSet(null, new AssertionError("Reader " + threadId + ": Expected " + randomSymbol + " but got " + foundSymbol));
-                                        return;
+                                        // It's OK if rowCount is 0 or 1 (symbol might not exist yet or might exist)
+                                        totalQueries.incrementAndGet();
                                     }
-
-                                    // It's OK if rowCount is 0 or 1 (symbol might not exist yet or might exist)
-                                    totalQueries.incrementAndGet();
                                 }
-                            }
 
-                            Os.sleep(rnd.nextInt(5) + 1);
-                        } catch (Exception e) {
-                            errorCount.incrementAndGet();
-                            firstError.compareAndSet(null, e);
-                            e.printStackTrace();
+                                Os.sleep(rnd.nextInt(5) + 1);
+                            } catch (Exception e) {
+                                errorCount.incrementAndGet();
+                                firstError.compareAndSet(null, e);
+                                e.printStackTrace();
+                            }
                         }
                     }
                 } catch (Exception e) {
