fix(core): fix table suspension due to indexing error (#5984)

bluestreak01 · web-flow · commit 100ff29532ee · 2025-07-23T14:26:56.000+01:00
diff --git a/core/src/main/java/io/questdb/cairo/O3OpenColumnJob.java b/core/src/main/java/io/questdb/cairo/O3OpenColumnJob.java
@@ -1528,7 +1528,18 @@ public static void openColumn(
                         srcDataOldPartitionSize,
                         o3SplitPartitionSize,
                         tableWriter,
-                        indexWriter,
+                        // Even though we are not using mapped memory for the last partition from the table writer
+                        // we must use its indexers to produce consistent index results. The condition here is
+                        // "creative" - we want to avoid bitmap index lookup for each and every column. We will use
+                        // presence of "indexWriter" as the guide. For columns that do not need indexing, this
+                        // writer would be null.
+
+                        // Consistent use of tableWriter's indexer is required because last partition could be updated
+                        // from two places, this is one of them. The other also uses tableWriter's index and is more
+                        // straightforward. Failure to make them consistent manifests when this site updates index and
+                        // extends its value memory, it may do so without extending key memory. Then key memory has
+                        // the reference to a value block, which would be outside the mapped area for tableWriters' indexer.
+                        openColumnMode == OPEN_LAST_PARTITION_FOR_APPEND && indexWriter != null ? tableWriter.getBitmapIndexWriter(columnIndex) : indexWriter,
                         colTopSinkAddr,
                         columnIndex,
                         columnNameTxn,
diff --git a/core/src/main/java/io/questdb/cairo/O3PartitionJob.java b/core/src/main/java/io/questdb/cairo/O3PartitionJob.java
@@ -296,24 +296,6 @@ public static void processParquetPartition(
                 LOG.error().$("could not truncate partition file [path=").$(path).I$();
             }
             ff.close(fd);
-            // delete all index files unconditionally
-            path.of(pathToTable);
-            setPathForNativePartition(path, partitionBy, partitionTimestamp, srcNameTxn);
-            final int pLen = path.size();
-            for (int i = 0, n = tableWriterMetadata.getColumnCount(); i < n; i++) {
-                if (tableWriterMetadata.getColumnType(i) == ColumnType.SYMBOL && tableWriterMetadata.isColumnIndexed(i)) {
-                    final CharSequence columnName = tableWriterMetadata.getColumnName(i);
-                    final long columnNameTxn = tableWriter.getColumnNameTxn(partitionTimestamp, i);
-                    final int indexBlockCapacity = tableWriterMetadata.getIndexValueBlockCapacity(i);
-                    if (indexBlockCapacity < 0) {
-                        continue;
-                    }
-
-                    BitmapIndexUtils.keyFileName(path.trimTo(pLen), columnName, columnNameTxn);
-                    BitmapIndexUtils.valueFileName(path.trimTo(pLen), columnName, columnNameTxn);
-                }
-            }
-
             tableWriter.o3BumpErrorCount(CairoException.isCairoOomError(th));
         } finally {
             path.of(pathToTable);
