Merged
Conversation
puzpuzpuz
reviewed
Sep 2, 2025
puzpuzpuz
reviewed
Sep 2, 2025
| description: ADD INDEX SQL keyword. Materialized Views reference documentation. | ||
| --- | ||
|
|
||
| Indexes an existing [`symbol`](/docs/concept/symbol/) column. Index capacity can be specified manually; |
Contributor
There was a problem hiding this comment.
nit: I'd remove the second sentence: index capacity is not something we want users to change, also they usually confuse it with symbol table capacity.
Contributor
Author
There was a problem hiding this comment.
But we do have syntax for it, so I guess we should document it.
Contributor
Author
There was a problem hiding this comment.
addressed this with the section about index capacity on index page and removing example
puzpuzpuz
reviewed
Sep 2, 2025
documentation/reference/sql/alter-mat-view-alter-column-add-index.md
Outdated
Show resolved
Hide resolved
puzpuzpuz
reviewed
Sep 2, 2025
|
|
||
| :::note | ||
|
|
||
| [Backup your database](/docs/operations/backup/) to avoid unintended data loss. |
Contributor
There was a problem hiding this comment.
Do we expect index drop to lead to data loss?
Contributor
Author
There was a problem hiding this comment.
I wouldn't. This is copy/paste from the alter table drop index page. I can remove it from both if you think it is safe?
Contributor
Author
There was a problem hiding this comment.
Removed the note from both pages
puzpuzpuz
reviewed
Sep 2, 2025
documentation/reference/sql/alter-mat-view-alter-column-drop-index.md
Outdated
Show resolved
Hide resolved
…t about index capacity
puzpuzpuz
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added docs pages for alter matview.. add index/drop index, related to questdb/questdb#5961
Changed concept pages for indices and matviews
Sorted the left sidebar slightly, as it was out of alphabetical order for some SQL subsections.