Skip to content

Commit 1df03dc

Browse files
alexyclaude
andcommitted
Link apache/datafusion#26058 from the respawn-fog workaround and NOTES
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 802e6bc commit 1df03dc

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎NOTES.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,12 @@ execution, which brings the 10 cores to 38.8 frames a second.
6868

6969
## Sail issues found
7070

71+
- Filed: [apache/datafusion#26058](https://github.com/apache/datafusion/issues/26058),
72+
wrong results on Sail main too: an inner join whose `ON` pairs an equi-key
73+
with an equality spanning two cross-joined relations loses the second
74+
(`extract_equijoin_predicate` with `eliminate_cross_join`). The game's
75+
respawn fog hit it; `tic_monsters.sql` writes one branch per fog instead.
76+
7177
- Filed: [lakehq/sail#2742](https://github.com/lakehq/sail/issues/2742), a
7278
`CASE` over arrays of structs panics when only a later branch has a NULL
7379
item (the renderer puts the nullable branch first to avoid it).

‎sql/tic_monsters.sql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -944,7 +944,7 @@ X4 AS (
944944
-- The teleport fog at the corpse (k = 0) and at the spawn spot (k = 1).
945945
-- One branch each: DataFusion's eliminate_cross_join drops an equi-join key
946946
-- that spans two relations, such as `s.id = CASE k.k ... END` over a cross
947-
-- join with the k values.
947+
-- join with the k values (apache/datafusion#26058).
948948
SELECT * FROM X3
949949
UNION ALL
950950
SELECT q.* FROM (

0 commit comments

Comments
 (0)