Validate a JSON response before checking response code#308
Merged
chattarajoy merged 1 commit intoqubole:unreleasedfrom Feb 27, 2020
Merged
Validate a JSON response before checking response code#308chattarajoy merged 1 commit intoqubole:unreleasedfrom
chattarajoy merged 1 commit intoqubole:unreleasedfrom
Conversation
sunasra
approved these changes
Feb 27, 2020
chattarajoy
added a commit
that referenced
this pull request
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen issues where Qubole API returns 404 HTML response from Nginx and the call fails with resource not found error with retries not kicking in.
Added change to check if it is a proper JSON Response first if it isn't it means that the response came directly from NGINX and didn't reach the web application. Raising Server Error in such cases so that retries can kick in and avoid intermittent issues.