Skip to content

Sdk-376: Adding support for multiple API versions in clusters#284

Merged
chattarajoy merged 24 commits intoqubole:unreleasedfrom
tarrygo:SDK-376
Oct 17, 2019
Merged

Sdk-376: Adding support for multiple API versions in clusters#284
chattarajoy merged 24 commits intoqubole:unreleasedfrom
tarrygo:SDK-376

Conversation

@tarrygo
Copy link
Copy Markdown
Contributor

@tarrygo tarrygo commented Sep 30, 2019

  1. Adding support for v2.2 API version for clusters
  2. Adding cluster composition.

@tarrygo tarrygo changed the title Sdk-376: cluster v2 changes Sdk-376: Adding support for multiple API versions in clusters Oct 15, 2019
@tarrygo
Copy link
Copy Markdown
Contributor Author

tarrygo commented Oct 15, 2019

@akaranjkar-qu Can you please review this PR. I am in the process of writing testcases. In the meanwhile can you please review and approve it. We need to release it urgently for cluster composition testing.

akaranjkar-qu
akaranjkar-qu previously approved these changes Oct 15, 2019
Copy link
Copy Markdown
Contributor

@akaranjkar-qu akaranjkar-qu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please remove the deepsource binary before merging

akaranjkar-qu
akaranjkar-qu previously approved these changes Oct 15, 2019
Copy link
Copy Markdown
Contributor

@akaranjkar-qu akaranjkar-qu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@chattarajoy chattarajoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes, @tarrygo will run regressions using the unreleased branch before releasing a new version.

@chattarajoy chattarajoy merged commit 8231a42 into qubole:unreleased Oct 17, 2019
chattarajoy pushed a commit that referenced this pull request Feb 18, 2020
This adds Support for multiple API versions in clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants