Add exception instead of "pass" to avoid silently skipping of write#205
Merged
msumit merged 1 commit intoqubole:unreleasedfrom Mar 19, 2019
Merged
Add exception instead of "pass" to avoid silently skipping of write#205msumit merged 1 commit intoqubole:unreleasedfrom
msumit merged 1 commit intoqubole:unreleasedfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have faced an issue when passing NamedTemporaryFile instance to get_results().
It silently skipped writing, which is very bad.
So to avoid this, commentary 'Can this happen? Don't know what's the right thing to do in this case.' and 'pass' should be replaced with 'raise ValueError()'.