-
Notifications
You must be signed in to change notification settings - Fork 27
File system capablity #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… update Docker setup
…ation, and improve WebSocket port handling
…ect path sanitization
|
Caution Review failedThe pull request is closed. WalkthroughThis update primarily changes the default WebSocket port from 8080 to 5010 across both the Unity Editor integration and the MCP server. It also adds comprehensive filesystem utility functions with asynchronous operations and robust path validation, integrates new Docker configuration files and metadata, and updates dependency versions. Additionally, the server startup process now dynamically determines the Unity project path, registers new filesystem tools, and improves error handling and logging, especially in the WebSocket handler. Changes
Sequence Diagram(s)sequenceDiagram
participant S as MCP Server
participant E as Environment
participant W as WebSocketHandler
participant U as Unity Editor
participant F as Filesystem Tools
S->>E: Read MCP_WEBSOCKET_PORT (default 5010)
S->>W: Initialize WebSocketHandler(port=5010)
S->>F: Register filesystem tools
W->>U: Accept connection request
U->>W: Send command (e.g., filesystem tool request)
W->>F: Dispatch tool handling
F-->>W: Return operation result
W->>U: Send back response message
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Docstrings generation was requested by @shahzadgamedev. * #6 (comment) The following files were modified: * `Editor/UI/MCPDebugWindow.cs` * `mcpServer/build/filesystemTools.js` * `mcpServer/build/toolDefinitions.js` * `mcpServer/src/filesystemTools.ts` * `mcpServer/src/toolDefinitions.ts`
|
Note Generated docstrings for this pull request at #7 |
This pull request includes several changes to the
mcpServerand Unity Editor connection management. The primary focus is updating the WebSocket port configuration and enhancing the MCP server's functionality with new filesystem tools.WebSocket Port Configuration Updates:
Editor/MCPConnectionManager.cs: Changed the default WebSocket server URI port from 8080 to 5010.Editor/UI/MCPDebugWindow.cs: Updated the default port in various UI elements and connection logic from 8080 to 5010. [1] [2] [3]mcpServer/.env.example: Added an example environment variable for the WebSocket port configuration.Docker and Environment Configuration:
mcpServer/Dockerfile: Added a Dockerfile to set up the MCP server environment, including setting the default WebSocket port to 5010.mcpServer/.dockerignore: Added a.dockerignorefile to exclude unnecessary files from the Docker build context.MCP Server Enhancements:
mcpServer/build/index.js: Enhanced the MCP server to dynamically determine the Unity project path, handle WebSocket port configuration, and register new filesystem tools. [1] [2]mcpServer/build/toolDefinitions.js: Introduced new filesystem tools for reading, writing, editing, and listing files and directories within the Unity project. [1] [2] [3]Minor Changes and Fixes:
mcpServer/build/websocketHandler.js: Updated the WebSocket handler to use the new default port and improved logging and error handling. [1] [2] [3] [4]mcpServer/build/types.js: Added new types for scene and game object information detail levels.These changes collectively improve the configurability and functionality of the MCP server and its integration with the Unity Editor.
Summary by CodeRabbit
New Features
Refactor