Conversation
…uartz section (#3106) The named AddQuartz(name, configuration) overload assumed the passed section was the scheduler's own section, reading flat properties and Schedule/Scheduling directly under it. When given the root Quartz section (with the schedule under Schedulers:{name}), nothing was registered. - The named overload now resolves the Schedulers:{name} sub-section when present, using it for both property conversion and JsonSchedulingHelper; otherwise it uses the section as-is (fully backward compatible). - The root AddQuartz(IConfiguration) overload now throws a clear SchedulerConfigException when a top-level Schedule/Scheduling section is combined with a Schedulers sub-section (previously silently dropped). Adds regression tests and documents the behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
This was referenced Jun 27, 2026
Merged
build(deps): Bump Quartz.AspNetCore from 3.18.1 to 3.18.2
eurofurence/ef-app_backend-dotnet-core#433
Merged
This was referenced Jun 29, 2026
Closed
This was referenced Jul 8, 2026
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Fixes #3106.
When configuring named schedulers under
Quartz:Schedulers:{name}and calling the namedAddQuartzoverload with the rootQuartzsection, nothing is registered (0 jobs, 0 triggers):The named overload assumed the section it received was the scheduler's own section, so it read flat properties and the
Schedule/Schedulingsub-sections directly under it. With the root section those live underSchedulers:{name}:..., so they were never found (properties were lost too, sinceSchedulersis a reserved/skipped key).Fix
AddQuartz(name, configuration)now resolves aSchedulers:{name}child when present and uses it for both property conversion andJsonSchedulingHelper; otherwise it uses the section as-is. Fully backward-compatible — the recursive call from the root overload and the existing flat-section usage are unaffected.AddQuartz(IConfiguration)overload now throws aSchedulerConfigExceptionwhen a top-levelSchedule/Schedulingsection is combined with aSchedulerssub-section. Previously that top-level scheduling data was silently dropped (it has no scheduler to attach to once named schedulers are in play).Tests & docs
AddQuartz_NamedScheduler_WithRootSectionContainingSchedulers_ResolvesSubsection(reproduction).AddQuartz_SchedulersWithTopLevelSchedule_Throws(guard).All
JsonSchedulingTestspass.🤖 Generated with Claude Code