Backport 4.x review fixes to 3.x JSON configuration#3015
Merged
Conversation
Port improvements from Copilot review rounds on the 4.x PR (#3014): - Validate TypeLoadHelper.LoadType return for null - Validate JobDataMap entries are non-null strings - Replace all raw Parse calls with TryParse + contextual errors (Priority, StartTime, EndTime, TimeSpan, Enum, bool) - Add SafeParseInt, SafeParseTimeSpan, SafeParseEnum helpers - Validate TimeOfDay range (00:00:00-23:59:59) with TryParse - Wrap CronScheduleBuilder.CronSchedule with try-catch - Simplify HasDirectSchedulerConfiguration to catch all non-reserved keys - Add license headers to all plugin files - Replace Constants-based misfire parsing with reflection in Plugins processor (avoids internal type dependency) - Add TestJsonSchedulingPlugin test for UseJsonSchedulingConfiguration Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports all improvements from Copilot review rounds on the 4.x PR (#3014) to the 3.x branch.
SchedulerConfigExceptionmessagesTypeLoadHelper.LoadTypereturn, JobDataMap entry valuesCronScheduleBuilder.CronSchedule()with try-catch, TimeOfDay range validationHasDirectSchedulerConfigurationto catch non-reserved scalar keys (typo detection)Constantsdependency),SchedulerExceptioncaptured in Start catch blockTestJsonSchedulingPluginforUseJsonSchedulingConfigurationextension methodTest plan
🤖 Generated with Claude Code