Port multiple named schedulers to 4.x#3003
Merged
Merged
Conversation
Port of 3.x PR #3000 to 4.x, adapted for main branch idioms: - Files in src/Quartz/Configuration/ and src/Quartz/Hosting/ (consolidated into core Quartz assembly) - ValueTask return types on interfaces (IJob, ISchedulerListener, etc.) - IHostedLifecycleService with Starting/Started/Stopping/Stopped hooks - GetDbConnectionManager (lowercase b) naming convention - ContainerConfigurationProcessor takes ILogger, TimeProvider - Collection literals [], ArgumentException.ThrowIfNullOrWhiteSpace - No #if conditional compilation or netstandard2.0 support - Full nullable reference types - 4.x docs under docs/documentation/quartz-4.x/packages/ Includes all review fixes from 3.x PR: - Duplicate name guard, shutdown resilience, partial startup cleanup - SchedulerName setter protection, InstantiateType isolation - UseJobFactory/UseTypeLoader/UsePersistentStore guards for named - Null matchers coalescing, idempotent hosted service registration - Instance name drift prevention via re-force after configure Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
- NamedSchedulerFactory.InstantiateType: throw clear InvalidOperationException instead of passing null to ObjectUtils.InstantiateType (guaranteed crash) - NamedSchedulerHostedService: re-throw OperationCanceledException after cleanup so host knows startup was aborted - ServiceCollectionQuartzConfigurator.RegisterSingleton: guard for named schedulers to prevent global DI contamination Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Main branch is the publish source for all docs including 3.x. Add the 3.x multiple-schedulers doc page, sidebar entry, and see-also links that were part of the 3.x PR (#3000). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of #3000 (3.x) to main (4.x), adapted for main branch architecture and idioms.
Changes from 3.x port
src/Quartz/Configuration/andsrc/Quartz/Hosting/(consolidated into core assembly, not separate Extension packages)ValueTaskreturn types on listener/job interfacesIHostedLifecycleServicewithStartingAsync/StartedAsync/StoppingAsync/StoppedAsynchooksGetDbConnectionManager(lowercase b) naming conventionContainerConfigurationProcessortakesILogger,TimeProviderdependencies[],ArgumentException.ThrowIfNullOrWhiteSpace#ifconditional compilation, nonetstandard2.0docs/documentation/quartz-4.x/packages/All review fixes from 3.x included
Test plan
🤖 Generated with Claude Code