Add UpdateTriggerDetails to update trigger metadata without rescheduling#2988
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ing (#844) Allow updating trigger properties like Description, Priority, JobDataMap, CalendarName, and MisfireInstruction without resetting fire times or trigger state. Uses the INextVersionJobStore internal interface pattern to maintain API compatibility on the 3.x branch. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
lahma
force-pushed
the
update-without-reschedule
branch
from
April 3, 2026 20:38
e8967e7 to
d759d05
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
There was a problem hiding this comment.
Pull request overview
Adds a new API surface to update selected trigger metadata in-place (without rescheduling) by introducing a TriggerDetailsUpdate “patch” object, plumbing support through QuartzScheduler/StdScheduler, and implementing the feature in both RAM and ADO job stores.
Changes:
- Introduces
TriggerDetailsUpdateandIScheduler.UpdateTriggerDetails()extension method for updating trigger metadata without resetting fire times/state. - Adds
INextVersionJobStore(internal, 3.x-compatible capability interface) and implementsUpdateTriggerDetailsinRAMJobStoreandJobStoreSupport(ADO). - Adds new unit tests covering update behavior and state/fire-time preservation.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Quartz/TriggerDetailsUpdate.cs | New “patch” type describing which trigger fields to update. |
| src/Quartz/SPI/IJobStore.cs | Adds internal INextVersionJobStore capability interface for 3.x. |
| src/Quartz/Simpl/RAMJobStore.cs | Implements in-memory trigger detail updates (incl. priority reordering). |
| src/Quartz/SchedulerExtensions.cs | Adds IScheduler.UpdateTriggerDetails() extension entry point. |
| src/Quartz/Impl/StdScheduler.cs | Proxies UpdateTriggerDetails to underlying QuartzScheduler. |
| src/Quartz/Impl/AdoJobStore/JobStoreSupport.cs | Adds ADO-backed implementation using delegate trigger update. |
| src/Quartz/Core/QuartzScheduler.cs | Exposes UpdateTriggerDetails and dispatches via INextVersionJobStore. |
| src/Quartz.Tests.Unit/UpdateTriggerDetailsTest.cs | New unit tests validating update semantics. |
- Fix empty JobDataMap not marking dirty flag (use ForceJobDataMapDirty) - Clone JobDataMap in RAMJobStore to prevent external mutation - Clarify docs that CalendarName/MisfireInstruction affect firing behavior - Add null check for scheduler in extension method - Use unique instanceName and serializer type in scheduler test Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
…rDetailsUpdate Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateTriggerDetailsmethod that updates trigger metadata (Description, Priority, JobDataMap, CalendarName, MisfireInstruction) without resetting fire times, trigger state, or misfire handling contextINextVersionJobStoreinternal interface pattern to maintain API compatibility on the 3.x branch (mirrors the existingINextVersionDelegatepattern)IScheduler.UpdateTriggerDetails()extension method and directly onStdScheduler/QuartzSchedulerCloses #844
Test plan
🤖 Generated with Claude Code