Fix spurious ERROR log on zombie transaction rollback#2978
Merged
Conversation
When a database connection is lost mid-operation, the transaction becomes disconnected (transaction.Connection == null). The rollback handler was logging this at ERROR level, alarming users even though the system handles it gracefully. Now detects disconnected transactions upfront and skips rollback with a Debug-level log, since there is nothing to rollback when the database has already aborted the transaction. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
2 tasks
This was referenced Apr 3, 2026
Merged
Closed
Merged
This was referenced Apr 10, 2026
This was referenced May 4, 2026
Closed
This was referenced May 12, 2026
This was referenced May 20, 2026
This was referenced Jun 1, 2026
This was referenced Jun 10, 2026
This was referenced Jun 21, 2026
This was referenced Jun 28, 2026
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transaction.Connection == null). The rollback handler now detects this upfront and skips rollback with a Debug-level log, since the database has already aborted the transactionConnectionAndTransactionHolder.Rollback()covering disconnected, connected, and null transaction scenariosTest plan
ConnectionAndTransactionHolderTesttests pass (3/3)🤖 Generated with Claude Code