Fix DoCheckin not retrying transient database errors (#2314)#2970
Merged
Conversation
DoCheckin was the only major DB operation path without transient retry logic. A transient error (e.g. Npgsql timeout) during cluster check-in would fail immediately, causing stale DB timestamps and potential false failure detection by other cluster nodes. Add retry loop matching ExecuteInNonManagedTXLock pattern, and fix ClusterCheckIn setting LastCheckin before the DB write succeeds. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
3 tasks
This was referenced Apr 3, 2026
Merged
Closed
Merged
This was referenced Apr 10, 2026
This was referenced May 4, 2026
Closed
This was referenced May 12, 2026
This was referenced May 20, 2026
This was referenced Jun 1, 2026
This was referenced Jun 10, 2026
This was referenced Jun 21, 2026
This was referenced Jun 28, 2026
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoCheckininJobStoreSupport, matching the existingExecuteInNonManagedTXLockpattern (usesMaxTransientRetries,TransientRetryInterval,IsTransient())ClusterCheckInsettingLastCheckinbefore the DB write succeeds — now only advances after commit, preventing stale in-memory timestamps on failureLastCheckincorrectnessCloses #2314
Test plan
dotnet test --filter "FullyQualifiedName~DoCheckin"— 4 new tests passdotnet test --filter "FullyQualifiedName~TriggersFired"— 7 existing tests still pass🤖 Generated with Claude Code