Fix StoreCalendar overriding paused trigger state (#2053)#2968
Merged
Conversation
When AddCalendar was called with updateTriggers=true, StoreTrigger was always called with StateWaiting, which would override any existing trigger state (PAUSED, BLOCKED, etc.). This caused manually paused jobs to automatically resume when their associated calendar was updated. Now reads the actual trigger state from the database and preserves it. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Tests verify that StoreCalendar with updateTriggers=true preserves the existing trigger state (PAUSED, BLOCKED, PAUSED_BLOCKED, WAITING, COMPLETE, ERROR) instead of overriding to WAITING. Also verifies that DELETED triggers are skipped and that mixed states on multiple triggers are preserved independently. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
lahma
added a commit
that referenced
this pull request
Mar 31, 2026
When AddCalendar was called with updateTriggers=true, StoreTrigger was always called with StateWaiting, which would override any existing trigger state (PAUSED, BLOCKED, etc.). This caused manually paused jobs to automatically resume when their associated calendar was updated. Now reads the actual trigger state from the database and preserves it. Port of #2968 from 3.x branch. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
2 tasks
lahma
added a commit
that referenced
this pull request
Mar 31, 2026
When AddCalendar was called with updateTriggers=true, StoreTrigger was always called with StateWaiting, which would override any existing trigger state (PAUSED, BLOCKED, etc.). This caused manually paused jobs to automatically resume when their associated calendar was updated. Now reads the actual trigger state from the database and preserves it. Port of #2968 from 3.x branch. Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
This was referenced Apr 3, 2026
Merged
Closed
Merged
This was referenced May 4, 2026
Closed
This was referenced May 12, 2026
This was referenced May 20, 2026
This was referenced Jun 1, 2026
This was referenced Jun 10, 2026
This was referenced Jun 21, 2026
This was referenced Jun 28, 2026
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddCalendarwithupdateTriggers=truewas unconditionally setting trigger state toWAITING, overriding any paused/blocked stateforceState: trueDELETEDstateTest plan
🤖 Generated with Claude Code