Fix RemoteScheduler ignoring local quartz.scheduler.instanceName (#313)#2953
Merged
Conversation
…er.instanceName (#313) RemoteScheduler.SchedulerName fetched the name from the remote server, ignoring the locally configured instanceName. This caused repository lookup/bind key mismatches and prevented multiple proxies to remotes sharing the same name. Add a constructor overload that accepts the local scheduler name, with fallback to the remote name for backwards compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The shutdown test mutates the singleton SchedulerRepository.Instance, so it needs try/finally cleanup and must not run in parallel with other fixtures that touch the repository. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoteScheduler.SchedulerNamefetched the name from the remote server, ignoring the locally configuredquartz.scheduler.instanceName. This causedSchedulerRepositorylookup/bind key mismatches (lookup by local name, bind by remote name) and prevented multiple proxies to remotes sharing the same scheduler name.RemoteSchedulerconstructor overload accepting the local scheduler name, with fallback to the remote name when using the existing constructor for full backwards compatibility.StdSchedulerFactoryto pass the configuredschedNameto the new constructor.Fixes #313
Test plan
dotnet test src/Quartz.Tests.Unit/Quartz.Tests.Unit.csproj --filter "FullyQualifiedName~RemoteScheduler"🤖 Generated with Claude Code