Skip to content

Optimize cron parsing#2769

Merged
lahma merged 2 commits into
3.xfrom
optimize-cron
Aug 2, 2025
Merged

Optimize cron parsing#2769
lahma merged 2 commits into
3.xfrom
optimize-cron

Conversation

@lahma

@lahma lahma commented Aug 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Quartz.Benchmark.CronExpressionBenchmark

Diff Method Toolchain Mean Error Allocated
Old CreateExpressionsAndCalculateFireTimeAfter Default 12.56 μs 0.129 μs 21.56 KB
New Default 10.687 μs (-15%) 0.1867 μs 16.48 KB (-24%)
Old CreateExpressionsAndCalculateFireTimeAfter Default 12.55 μs 0.047 μs 24.56 KB
New Default 10.354 μs (-17%) 0.1038 μs 18.28 KB (-26%)
Old CreateExpressionsAndCalculateFireTimeAfter Default 11.93 μs 0.148 μs 19.02 KB
New Default 9.681 μs (-19%) 0.1570 μs 15.04 KB (-21%)
Old CreateExpressionsAndCalculateFireTimeAfter Default 13.13 μs 0.074 μs 25.78 KB
New Default 10.763 μs (-18%) 0.0749 μs 19.23 KB (-25%)
Old CreateExpressionsAndCalculateFireTimeAfter Default 14.83 μs 0.208 μs 26.07 KB
New Default 10.439 μs (-30%) 0.0860 μs 19.34 KB (-26%)
Old CreateExpressionsAndCalculateFireTimeAfter Default 13.26 μs 0.135 μs 26.07 KB
New Default 11.291 μs (-15%) 0.1250 μs 19.34 KB (-26%)

@github-actions

github-actions Bot commented Aug 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

3 new problems were found

Inspection name Severity Problems
Expression is always 'true' or 'false' according to nullable reference types' annotations 🔶 Warning 1
Use preferred style for trailing comma before new line in multiline lists ◽️ Notice 1
RoslynAnalyzers Mark members as static ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@sonarqubecloud

sonarqubecloud Bot commented Aug 2, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lahma
lahma merged commit 593eaa4 into 3.x Aug 2, 2025
11 of 12 checks passed
@lahma
lahma deleted the optimize-cron branch August 2, 2025 09:29
This was referenced Aug 4, 2025
Closed
Open
Closed
Open
Open
Closed
Merged
Closed
Closed
Closed
Closed
Open
Closed
This was referenced Aug 19, 2025
Closed
Merged
This was referenced Aug 27, 2025
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Oct 27, 2025
Open
@dependabot dependabot Bot mentioned this pull request Nov 11, 2025
Closed
This was referenced Dec 25, 2025
Merged
Merged
This was referenced Jan 16, 2026
Closed
Closed
This was referenced Mar 2, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Mar 19, 2026
Closed
This was referenced Mar 30, 2026
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
This was referenced Apr 13, 2026
Closed
Merged
This was referenced Apr 22, 2026
Closed
Closed
Closed
Open
Open
@dependabot dependabot Bot mentioned this pull request May 22, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jun 29, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 8, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lahma