fix mdx-code-block special code block for docusaurus#8339
Merged
Conversation
…here is whitespace after backtick like pandoc is creating from CodeBlock
cscheid
reviewed
Jan 18, 2024
Collaborator
|
I think we need to merge this because we're providing the translation of blocks like this into We don't want Quarto to regress regress here, independently of how brittle Docusaurus is on this respect. |
Collaborator
Author
|
I agree, that is why I open the PR. I'll undraft and let you merge if we go for it for 1.4 I did not add a new tst by the way, but just adapted the existing one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not handled by docusaurus if there is whitespace after backtick like pandoc is creating from CodeBlock
This fixes #8333
Though from discussion there, it could also be an issue in docusaurus itself that they should fix as it is breaking from V2 to V3
and it does not seem they mention this change as known (cc @eitsupi)
Their checker (https://github.com/slorber/docusaurus-mdx-checker) does not warn on the produced file with a space also
So opening as draft to keep this if we decide to merge it