Fix notebook-view.url being ignored

cderv · cderv · commit 82013bd50af2 · 2025-11-19T11:39:10.000+01:00
When notebook-view.url is specified, notebook links should point to the external URL instead of rendering a local preview. This was broken in v1.4.156 (commit faba735) when the notebook system was refactored and external URL handling was accidentally removed. The fix restores the check for descriptor?.url before falling back to the local preview path in format-html-notebook-preview.ts. Updated existing test to verify links contain the external URL. (cherry picked from commit a39cc61) Move changelog entry as backport in v1.8 # Conflicts: # news/changelog-1.9.md
diff --git a/news/changelog-1.8.md b/news/changelog-1.8.md
@@ -2,6 +2,8 @@
 
 ## In this release
 
+- ([#13694](https://github.com/quarto-dev/quarto-cli/issues/13694)): Fix `notebook-view.url` being ignored - external notebook links now properly use specified URLs instead of local preview files.
+
 ## In previous releases
 
 - ([#13369](https://github.com/quarto-dev/quarto-cli/issues/13369)): Fix failure in theme compilation when `brand.color.primary` is specified for light or dark but not both.
diff --git a/src/format/html/format-html-notebook-preview.ts b/src/format/html/format-html-notebook-preview.ts
@@ -252,7 +252,7 @@ export const notebookPreviewer = (
         // to form links to this notebook
         const nbPreview = {
           title: resolvedTitle,
-          href: relative(inputDir, renderedNotebook[kHtmlPreview].hrefPath),
+          href: descriptor?.url || relative(inputDir, renderedNotebook[kHtmlPreview].hrefPath),
           supporting,
           resources,
           order: work.order,
diff --git a/tests/docs/smoke-all/2023/01/05/notebook-preview-complex.qmd b/tests/docs/smoke-all/2023/01/05/notebook-preview-complex.qmd
@@ -29,7 +29,7 @@ _quarto:
   tests:
     html:
       ensureHtmlElements:
-        - ['a.quarto-notebook-link']
+        - ['a.quarto-notebook-link[href*="kaggle.com"]']
         - ['div.quarto-alternate-notebooks a']
       ensureFileRegexMatches:
         - ['Source: TEST NB']
