Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an ordering bug in RESTEasy Reactive runtime handler assembly where @WithFormRead request filters were moved after the body handler but ended up reversed due to backward iteration and append order.
Changes:
- Preserve the original relative order of
@WithFormReadrequest filters when relocating them after body handling. - Add a regression test that verifies multiple
@WithFormReadfilters execute according to theirpriorityvalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| independent-projects/resteasy-reactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/core/startup/RuntimeResourceDeployment.java | Adjusts filter relocation logic to keep @WithFormRead filters in the same order they had before being moved. |
| extensions/resteasy-reactive/rest/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/customproviders/WithFormReadFilterPriorityTest.java | Adds a regression test ensuring @WithFormRead filters run in increasing priority order. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+305
to
+309
| for (int i = handlers.size() - 2; i >= 0; i--) { | ||
| var serverRestHandler = handlers.get(i); | ||
| if (serverRestHandler instanceof ResourceRequestFilterHandler resourceRequestFilterHandler) { | ||
| if (resourceRequestFilterHandler.isWithFormRead()) { | ||
| readBodyRequestFilters.add(handlers.remove(i)); | ||
| readBodyRequestFilters.add(0, handlers.remove(i)); |
Contributor
Author
|
Taken, For the record on the cost, the list only ever holds the Same verification as before, on and with the |
…y handler The filters are collected while walking the handler list backwards, because they are removed by index as we go, but the collected list was then appended as it was. That reversed them, so priorities were applied in reverse order. Insert each match at the front instead, which is what the existing comment already says should happen.
…ront Addresses review feedback: add(0, ..) on an ArrayList shifts elements on every insert. Collect with a plain append and flip the list once before appending it back.
geoand
force-pushed
the
fix/withformread-filter-priority-order
branch
from
September 21, 2026 05:52
ea21c97 to
d052944
Compare
Status for workflow
|
geoand
approved these changes
Sep 21, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeResourceDeploymentmoves@WithFormReadrequest filters to the end of the handler list once the body handler is in place. It walks the list backwards, because it removes by index as it goes, but it then appended the collected filters in that same backwards order, so the filters ended up reversed and priorities were applied in reverse.The fix inserts each match at the front of the collected list instead, which keeps the order the handlers were already in. That is what the comment on the block already said should happen.
Added a test with three
@WithFormReadfilters atUSER + 100,USER + 200andUSER + 300that each append their name to a header, in the style of the existingReadBodyRequestFilterTest. With the fix it getsfirst/second/third; without it the same test getsthird/second/first.ReadBodyRequestFilterTest,ImpliedReadBodyRequestFilterTest,WithFormBodyTestandAnotherValidNonBlockingFiltersTeststill pass, 13 tests in total.