Skip to content

Rename SPIFFE enum value to SPIFFE_JWT#53919

Merged
sberyozkin merged 1 commit intoquarkusio:mainfrom
sberyozkin:rename_spiffe_enum
May 3, 2026
Merged

Rename SPIFFE enum value to SPIFFE_JWT#53919
sberyozkin merged 1 commit intoquarkusio:mainfrom
sberyozkin:rename_spiffe_enum

Conversation

@sberyozkin
Copy link
Copy Markdown
Member

@sberyozkin sberyozkin commented May 3, 2026

This PR renames a SPIFFE enum value to SPIFFE_JWT in anticipation of #53894 that will bring SPIFFE_WIT.

SPIFFE_JWT_SVID would be too long for users to type IMHO, so a SPIFFE_JWT shortcut should do

@sberyozkin sberyozkin requested a review from michalvavrik May 3, 2026 18:52
@quarkus-bot quarkus-bot Bot added area/docstyle issues related for manual docstyle review area/documentation area/oidc labels May 3, 2026
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented May 3, 2026

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 131c07a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented May 3, 2026 •
edited by github-actions Bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 131c07a.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Integration Tests - JDK 17 Logs Raw logs 🔍
✔️ JVM Integration Tests - JDK 17 Windows Logs Raw logs 🔍
✔️ JVM Integration Tests - JDK 21 Logs Raw logs 🔍
✔️ JVM Integration Tests - JDK 25 Logs Raw logs 🔍
❌ JVM Integration Tests - JDK 25 Semeru Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ JVM Integration Tests - JDK 25 Semeru #

- Failing: integration-tests/oidc-wiremock

📦 integration-tests/oidc-wiremock

❌ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.4:test (default-test) on project quarkus-integration-test-oidc-wiremock:

See /home/runner/work/quarkus/quarkus/integration-tests/oidc-wiremock/target/surefire-reports for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

michalvavrik
michalvavrik approved these changes May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. I am open on different names if other reviewers have different preferences.

@michalvavrik michalvavrik requested a review from gastaldi May 3, 2026 20:39
gastaldi
gastaldi approved these changes May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a migration script in https://github.com/quarkusio/quarkus-updates

@sberyozkin
Copy link
Copy Markdown
Member Author

sberyozkin commented May 3, 2026

Thanks @michalvavrik @gastaldi

That is on main only so we have no breaking change

@michalvavrik
Copy link
Copy Markdown
Member

michalvavrik commented May 3, 2026

Don't forget to add a migration script in https://github.com/quarkusio/quarkus-updates

I think it was introduced in 3.36 #53773 which I didn't find in https://github.com/quarkusio/quarkus/releases yet so if it goes in soon, it may not be a breaking change.

@sberyozkin sberyozkin merged commit b86a924 into quarkusio:main May 3, 2026
37 of 38 checks passed
@quarkus-bot quarkus-bot Bot added this to the 3.36 - main milestone May 3, 2026
@sberyozkin sberyozkin deleted the rename_spiffe_enum branch May 3, 2026 21:23
@sberyozkin
Copy link
Copy Markdown
Member Author

sberyozkin commented May 3, 2026

@michalvavrik @gastaldi I merged and realized there was a build failure on semeru in the test updated in the PR,
but it is not related, looks like a class loading issue:

2026-05-03T19:31:14.8429264Z 2026-05-03 19:31:08,551 INFO  [org.eclipse.aether.internal.impl.filter.GroupIdRemoteRepositoryFilterSource] (main) Loaded 1 groupId for remote repository gradle
2026-05-03T19:31:16.4579209Z java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
2026-05-03T19:31:16.4583063Z 	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#validate threw an exception: java.lang.NullPointerException: Cannot invoke "io.quarkus.arc.processor.InjectionPointInfo.isProgrammaticLookup()" because "injectionPoint" is null
2026-05-03T19:31:16.4585219Z 	at io.quarkus.arc.processor.UnusedBeans.findRemovableBeans(UnusedBeans.java:44)
2026-05-03T19:31:16.4586285Z 	at io.quarkus.arc.processor.BeanDeployment.removeUnusedBeans(BeanDeployment.java:502)
2026-05-03T19:31:16.4588016Z 	at io.quarkus.arc.processor.BeanDeployment.removeUnusedComponents(BeanDeployment.java:411)
2026-05-03T19:31:16.4589181Z 	at io.quarkus.arc.processor.BeanDeployment.init(BeanDeployment.java:358)
2026-05-03T19:31:16.4589892Z 	at io.quarkus.arc.processor.BeanProcessor.initialize(BeanProcessor.java:177)
2026-05-03T19:31:16.4591048Z 	at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:491)
2026-05-03T19:31:16.4591801Z 	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:735)
2026-05-03T19:31:16.4592699Z 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:811)
2026-05-03T19:31:16.4593529Z 	at io.quarkus.builder.BuildContext.run(BuildContext.java:242)
2026-05-03T19:31:16.4594339Z 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
2026-05-03T19:31:16.4595339Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2651)
2026-05-03T19:31:16.4596382Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2630)
2026-05-03T19:31:16.4597450Z 	at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1622)
2026-05-03T19:31:16.4598608Z 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1589)
2026-05-03T19:31:16.4599575Z 	at java.base/java.lang.Thread.run(Thread.java:1485)
2026-05-03T19:31:16.4600456Z 	at org.jboss.threads.JBossThread.run(JBossThread.java:501)
2026-05-03T19:31:16.4603039Z 
2026-05-03T19:31:16.4603777Z 	at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:441)
2026-05-03T19:31:16.4606001Z 	at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:355)
2026-05-03T19:31:16.4608317Z 	at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:65)
2026-05-03T19:31:16.4610357Z 	at io.quarkus.test.junit.AppMakerHelper.getStartupAction(AppMakerHelper.java:195)
2026-05-03T19:31:16.4612361Z 	at io.quarkus.test.junit.classloading.FacadeClassLoader.getOrCreateRuntimeClassLoader(FacadeClassLoader.java:582)
2026-05-03T19:31:16.4615685Z 	at io.quarkus.test.junit.classloading.FacadeClassLoader.getQuarkusClassLoader(FacadeClassLoader.java:482)
2026-05-03T19:31:16.4622427Z 	at io.quarkus.test.junit.classloading.FacadeClassLoader.loadClass(FacadeClassLoader.java:366)

Have a good evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gastaldi gastaldi gastaldi approved these changes

+1 more reviewer

@michalvavrik michalvavrik michalvavrik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/docstyle issues related for manual docstyle review area/documentation area/oidc

Projects

None yet

Milestone

3.36 - main

Development

Successfully merging this pull request may close these issues.

3 participants

@sberyozkin @michalvavrik @gastaldi