Skip to content

Add detailed Javadoc for ApplicationInfoBuildItem class - #47374

Merged
geoand merged 1 commit into
quarkusio:mainfrom
omatheusmesmo:docs/add-javadocs-to-build-items
Apr 16, 2025
Merged

geoand merged 1 commit into
quarkusio:mainfrom
omatheusmesmo:docs/add-javadocs-to-build-items

Conversation

@omatheusmesmo

Copy link
Copy Markdown
Contributor

Hi!

Please let me know if any changes are needed. This is my first PR here, so there might be something wrong beyond what I understood from the CONTRIBUTING.md .

Related to issue #37290

Path: core/deployment/src/main/java/io/quarkus/deployment/builditem/ApplicationInfoBuildItem.java

@quarkus-bot

quarkus-bot Bot commented Apr 15, 2025

Copy link
Copy Markdown

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

@omatheusmesmo omatheusmesmo changed the title docs: Add detailed Javadoc for ApplicationInfoBuildItem class Add detailed Javadoc for ApplicationInfoBuildItem class Apr 15, 2025
@omatheusmesmo

Copy link
Copy Markdown
Contributor Author

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

Fixed.

@mathecruz

Copy link
Copy Markdown
Contributor

LGTM, wdyt @gastaldi @gsmet?

I think we could do a new effort to document our build items.

@geoand

geoand commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Thanks for this.

Can you please squash the commits and force push?

@omatheusmesmo
omatheusmesmo force-pushed the docs/add-javadocs-to-build-items branch from 342365c to 630a44b Compare April 15, 2025 20:47
@omatheusmesmo
omatheusmesmo force-pushed the docs/add-javadocs-to-build-items branch 2 times, most recently from 7db9ee5 to 4ae8498 Compare April 15, 2025 21:26
@quarkus-bot

This comment has been minimized.

@omatheusmesmo

This comment has been minimized.

@omatheusmesmo
omatheusmesmo force-pushed the docs/add-javadocs-to-build-items branch from 4ae8498 to 29a89f7 Compare April 16, 2025 00:15

@geoand geoand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand
geoand merged commit 95fa5c6 into quarkusio:main Apr 16, 2025
@quarkus-bot quarkus-bot Bot added this to the 3.22 - main milestone Apr 16, 2025
@omatheusmesmo

Copy link
Copy Markdown
Contributor Author

Thanks you all, @geoand @mcruzdev @gastaldi !

@geoand

geoand commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants